QA

library/Msd/Dump.php

@@ -44,7 +44,7 @@ class Msd_Dump
     {
         $taskList          = Msd_TaskManager::getInstance('backupTasks', true);
         $this->dbsToBackup = $this->_getDbsToBackup();
-        $dbNames=array_keys($this->dbsToBackup);
+        $dbNames           = array_keys($this->dbsToBackup);
         foreach ($dbNames as $dbName) {
             $sumInfo = $this->_getDatabaseSums($dbName);
             $this->_addDatabaseSums($sumInfo);
@@ -52,7 +52,7 @@ class Msd_Dump
         }
         // set db to be dumped first -> start index is needed
         $this->dbActual = $dbNames[0];
-        //Debug::out($taskList->getTasks());
+        //var_dump($taskList->getTasks());
     }
 
     /**
@@ -88,9 +88,9 @@ class Msd_Dump
     /**
      * Get sum of tables, records and data size grouped by table type
      *
-     * @param string $db The database to check
+     * @param string $dbName The database to check
      *
-     * @return void
+     * @return array
      */
     private function _getDatabaseSums($dbName)
     {
@@ -130,7 +130,7 @@ class Msd_Dump
             if (!isset($this->sumTotal['tables'][$type])) {
                 $this->sumTotal['tables'][$type] = $this->_initSum();
             }
-            $this->sumTotal['tables'][$type] =$this->_sumAdd(
+            $this->sumTotal['tables'][$type] = $this->_sumAdd(
                 $this->sumTotal['tables'][$type], $sum[$type]
             );
             $this->sumTotal['tablesTotal'] += $sum[$type]['tablesTotal'];
@@ -185,6 +185,7 @@ class Msd_Dump
                       'table' => $table['TABLE_NAME']
                 )
             );
+
             // add dump data
             if ($table['TABLE_TYPE'] === 'BASE TABLE') {
                 $taskList->addTask(
@@ -194,6 +195,7 @@ class Msd_Dump
                     )
                 );
             }
+
             // add keys and indexes
             $taskList->addTask(
                 Msd_TaskManager::GET_ALTER_TABLE_ADD_KEYS,

library/Msd/Registry.php

@@ -62,7 +62,7 @@ class Msd_Registry extends Zend_Registry
      */
     public static function setConfig(Msd_Config $config)
     {
-        self::set(self::CONFIG_KEY . '', $config);
+        self::set(self::CONFIG_KEY, $config);
     }
 
     /**

library/Msd/TaskManager.php

@@ -106,7 +106,7 @@ class Msd_TaskManager
      *
      * @param string $type
      *
-     * @return array|false
+     * @return array|bool
      */
     public function getTasks($type = '')
     {